fix: change update mode types from int to quint64#95
Merged
Conversation
1. Changed update mode related types from int/uint to quint64 for consistency with D-Bus interface 2. Added refreshUpdateItemsChecked() method to properly update item checked states when mode changes 3. Fixed debounce timer to use quint64 for CheckUpdateMode property changes 4. Updated all related method signatures and property types to match These changes were necessary because: 1. The D-Bus interface uses 64-bit unsigned integers for update modes 2. Using smaller types could cause data truncation and incorrect behavior 3. The refresh logic needed to be separated from status refresh for better maintainability 4. Ensures type safety across the entire update mode handling chain fix: 将更新模式类型从 int 改为 quint64 1. 将更新模式相关类型从 int/uint 改为 quint64 以保持与 D-Bus 接口一致 2. 添加 refreshUpdateItemsChecked() 方法以便在模式变更时正确更新项目选中 状态 3. 修复防抖定时器使用 quint64 处理 CheckUpdateMode 属性变更 4. 更新所有相关方法签名和属性类型以匹配 这些变更是必要的因为: 1. D-Bus 接口使用 64 位无符号整数表示更新模式 2. 使用较小类型可能导致数据截断和错误行为 3. 需要将刷新逻辑与状态刷新分离以提高可维护性 4. 确保整个更新模式处理链的类型安全 pms: Bug-313905
mhduiy
approved these changes
May 29, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were necessary because:
fix: 将更新模式类型从 int 改为 quint64
这些变更是必要的因为:
pms: Bug-313905